add min/maximum(abs) #196
Closed
add min/maximum(abs) #196
+71
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 99.11% 96.65% -2.46%
==========================================
Files 6 6
Lines 225 299 +74
==========================================
+ Hits 223 289 +66
- Misses 2 10 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cstjean
reviewed
Nov 26, 2024
hyrodium
reviewed
Jan 1, 2025
Co-authored-by: Yuto Horikawa <[email protected]>
|
bump I guess... |
|
anybody?.. |
|
If you want someone to merge this then make sure all the tests are passing |
hyrodium
requested changes
Oct 19, 2025
There was a problem hiding this comment.
Sorry for the late review. I found a edge case.
julia> minimum(abs, 1..2)
1
julia> minimum(abs, 1..1) # This should return 1
ERROR: ArgumentError: cannot determine minimum(abs, 1 .. 1)
Stacktrace:
[1] minimum(::typeof(abs), I::ClosedInterval{Int64})
@ IntervalSets ~/.julia/dev/IntervalSets/src/IntervalSets.jl:355
[2] top-level scope
@ REPL[11]:1
|
probably makes sense to define these elsewhere, there's more useful functions than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.